Expose package SdkType in Apiview URI #12562
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API review submission scripts to include package type information in API review requests. The changes enable the scripts to pass the SdkType property from package metadata through to the APIView service.
Key Changes:
- Added
$packageTypeparameter to API review submission functions - Extracted package type from
packageInfo.SdkTypemetadata - Updated function calls to pass package type through the request chain
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/Detect-Api-Changes.ps1 | Adds packageType parameter to Submit-Request function and passes it from packageInfo.SdkType |
| eng/common/scripts/Create-APIReview.ps1 | Adds packageType parameter to Upload-SourceArtifact and Upload-ReviewTokenFile functions, extracting value from packageInfo.SdkType |
maririos
requested review from
AlitzelMendez,
praveenkuttappan and
tjprescott
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12562 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: helen229 <[email protected]>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12562 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: helen229 <[email protected]>
|
merging because all the sync PRs have merged and I don't want eng/common to be out of sync |
@raych1 @helen229 I don't think this needs an update. It just checks the status of API review so no need to pass SDK type. |
6 participants
Closes #12242
corresponding PR for API view side changes:
#12398
Same as #12323, this pr could not merge due to build issue, creating a new branch to resolve the issue.
This PR updates the API review submission scripts to include package type information in API review requests. The changes enable the scripts to pass the SdkType property from package metadata through to the APIView service.
Key Changes:
Added $packageType parameter to API review submission functions
Extracted package type from packageInfo.SdkType metadata
Updated function calls to pass package type through the request chain